Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): fix sessions not showing on dashboard #2608

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

leafty
Copy link
Member

@leafty leafty commented Jun 19, 2023

Fixes #2593.

Explanation: the current version of the code runs notebookCoordinator.fetchNotebooks() only the first time the Dashboard component is rendered.

/deploy #persist #cypress

@leafty leafty marked this pull request as ready for review June 19, 2023 13:56
@leafty leafty requested a review from a team as a code owner June 19, 2023 13:56
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2608.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-2608 June 19, 2023 14:00 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-2608 June 19, 2023 15:03 — with GitHub Actions Inactive
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to re-write the older class components 👍

Tbf I believe the original issue was fixed already in the latest version; I couldn't reproduce the problem on dev. Nevertheless this change is very welcome 😄

@leafty
Copy link
Member Author

leafty commented Jun 19, 2023

Good to re-write the older class components 👍

Tbf I believe the original issue was fixed already in the latest version; I couldn't reproduce the problem on dev. Nevertheless this change is very welcome 😄

It's easy to reproduce on the current UI: pick two projects, start a session in one, go to the other, list sessions (empty) then go to the dashboard.

@leafty leafty temporarily deployed to renku-ci-ui-2608 June 20, 2023 09:36 — with GitHub Actions Inactive
@leafty leafty deployed to renku-ci-ui-2608 June 20, 2023 11:09 — with GitHub Actions Active
@leafty
Copy link
Member Author

leafty commented Jun 21, 2023

Note: successfully ran cypress acceptance tests locally.

@leafty leafty merged commit ff08a51 into master Jun 21, 2023
@leafty leafty deleted the leafty/2593-fix-dashboard-sessions branch June 21, 2023 08:24
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Active sessions do not always show up in the dashboard
3 participants