Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): adapt slug and name of dataset (#2723) #2854

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Oct 17, 2023

PR to adjust the dataset slug and name in alignment with the updated Renku service and KG API, which now return slug and name instead of name and title.

Please note that the requests to Renku service for datasets now require the use of the slug rather than the name.

In this update, what was previously referred to as title has been changed to name, and name has now become slug.

  • Pending
  • Update renku cypress test
  • Test Renku service for compatibility, given the issue with the version, as Renku Core has not yet released an updated version.

Fix #2723
/deploy renku=ds-slug-title-name-change renku-graph=1511-ds-slug-name-only renku-core=develop extra-values=global.renku.cli_version=2.8.0rc3 #persist

@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 17, 2023 14:17 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2854.dev.renku.ch

@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 17, 2023 21:03 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 18, 2023 08:23 — with GitHub Actions Inactive
@andre-code andre-code force-pushed the andrea/2723-adapt-slug-and-name-dataset-kg branch from ea9da3b to 43cfe11 Compare October 18, 2023 14:51
@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 18, 2023 14:52 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 19, 2023 07:54 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 19, 2023 08:04 — with GitHub Actions Inactive
@andre-code andre-code marked this pull request as ready for review October 19, 2023 08:05
@andre-code andre-code requested a review from a team as a code owner October 19, 2023 08:05
@andre-code andre-code changed the title [wip] feat: adapt slug and name of kg dataset (2723) feat(client): adapt slug and name of kg dataset (2723) Oct 19, 2023
@andre-code andre-code changed the title feat(client): adapt slug and name of kg dataset (2723) feat(client): adapt slug and name of kg dataset (#2723) Oct 19, 2023
@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 19, 2023 08:06 — with GitHub Actions Inactive
@andre-code andre-code changed the title feat(client): adapt slug and name of kg dataset (#2723) feat(client): adapt slug and name of dataset (#2723) Oct 19, 2023
@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 19, 2023 11:32 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 19, 2023 11:40 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 19, 2023 14:38 — with GitHub Actions Inactive
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look very good -- even though there are changes spread out over dozens of files, they were easy to review.

But testing the changes is difficult for the reasons you mentioned about the version conflict that arises after doing anything on a project. I'm ok with approving or with waiting and re-testing after the version conflict issues are resolved.

@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 24, 2023 08:13 — with GitHub Actions Inactive
ciyer
ciyer previously approved these changes Oct 24, 2023
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked around and made changes to datasets, and everything looks good after this change. 🚀

@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 24, 2023 14:24 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 24, 2023 15:05 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 24, 2023 15:17 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 24, 2023 15:22 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2854 October 24, 2023 17:31 — with GitHub Actions Inactive
@andre-code andre-code force-pushed the andrea/2723-adapt-slug-and-name-dataset-kg branch from 6ff135c to 4056fdb Compare October 31, 2023 12:40
@andre-code andre-code merged commit 772f7db into master Nov 30, 2023
@andre-code andre-code deleted the andrea/2723-adapt-slug-and-name-dataset-kg branch November 30, 2023 12:35
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt slug and names on KG datasets APIs
6 participants