-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): adapt slug and name of dataset (#2723) #2854
feat(client): adapt slug and name of dataset (#2723) #2854
Conversation
You can access the deployment of this PR at https://renku-ci-ui-2854.dev.renku.ch |
ea9da3b
to
43cfe11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look very good -- even though there are changes spread out over dozens of files, they were easy to review.
But testing the changes is difficult for the reasons you mentioned about the version conflict that arises after doing anything on a project. I'm ok with approving or with waiting and re-testing after the version conflict issues are resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked around and made changes to datasets, and everything looks good after this change. 🚀
6ff135c
to
4056fdb
Compare
2c6e6b8
to
64106da
Compare
Tearing down the temporary RenkuLab deplyoment for this PR. |
PR to adjust the dataset slug and name in alignment with the updated Renku service and KG API, which now return slug and name instead of name and title.
Please note that the requests to Renku service for datasets now require the use of the
slug
rather than thename
.In this update, what was previously referred to as
title
has been changed toname
, andname
has now becomeslug
.Fix #2723
/deploy renku=ds-slug-title-name-change renku-graph=1511-ds-slug-name-only renku-core=develop extra-values=global.renku.cli_version=2.8.0rc3 #persist