feat: show a confirmation text when saving a session #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-code
temporarily deployed
to
renku-ci-ui-2856
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-2856.dev.renku.ch |
andre-code
force-pushed
the
andrea/2792-feedback-save-session-btn
branch
from
24d7dc8 to
d358886
Compare
andre-code
temporarily deployed
to
renku-ci-ui-2856
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2856
GitHub Actions
Inactive
leafty
requested changes
Oct 23, 2023
| @@ -295,8 +308,8 @@ function SaveSessionBody({ | |||
| undefined | |||
| ); | |||
| const saveText = saving ? ( | |||
| <span> | |||
| <Loader className="me-1" inline size={16} /> | |||
| <span className="d-flex gap-2"> | |||
There was a problem hiding this comment.
We should avoid doing this, the alignment is not correct here.
See here:
When inline is passed to <Loader>, it is meant to be inserted in the normal flow of a text. Separation can be achieved by using margin classes, e.g. me-1 or ms-1.
See correct alignment here:
<span>
<Loader className="me-2" inline size={16} />
Saving Session
</span>| @@ -53,6 +52,7 @@ import { | |||
| useRenkuSaveMutation, | |||
| } from "../sidecarApi"; | |||
| import styles from "./SessionModals.module.scss"; | |||
| import { SuccessAlert } from "../../../components/Alert"; | |||
There was a problem hiding this comment.
fix import order (vscode "Organize imports" command)
andre-code
temporarily deployed
to
renku-ci-ui-2856
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2856
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2856
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2856
GitHub Actions
Inactive
…ary text when saving session, fix spacing in button when save a session
andre-code
force-pushed
the
andrea/2792-feedback-save-session-btn
branch
from
76cb5f3 to
c3af9d1
Compare
andre-code
temporarily deployed
to
renku-ci-ui-2856
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2856
GitHub Actions
Inactive
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to introduce a confirmation message upon a successful session save. Additionally, it addresses minor issues, such as removing duplicate "saving session" messages and adjusting the spacing between text and the icon in the button.
Fix #2792
/deploy renku=renku-ui-3.14.1 #persist