refactor(client): make all fixtures use default options #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciyer
requested changes
Oct 27, 2023
Comment on lines
143
to
145
| interface GetStatuspageInfoArgs extends SimpleFixture { | ||
| overrides?: { [key: string]: unknown }; | ||
| } |
There was a problem hiding this comment.
I like how you have put effort into unifying the types around some standard patterns. I think this could be added to that catalog as well:
interface FixtureWithOverrides extends SimpleFixture {
overrides?: { [key: string]: unknown };
}
| const { | ||
| fixture = "projects/project.json", | ||
| name = "getProject", | ||
| path = "", |
There was a problem hiding this comment.
Suggested change
| path = "", | |
| projectPath = "", |
ciyer
requested changes
Oct 27, 2023
…rom the main settings page
ciyer
requested changes
Oct 30, 2023
| const response = { body: {}, statusCode: 500 }; | ||
| cy.intercept( | ||
| "GET", | ||
| "https://*.statuspage.io/api/v2/summary.jsonr", |
There was a problem hiding this comment.
This is a mistake introduced by my PR, but I will fix it in #2871
Co-authored-by: Chandrasekhar Ramakrishnan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: