Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shape up] Renku Native Projects #2875

Merged
merged 16 commits into from
Feb 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,10 @@ We use [CSS modules](https://github.com/css-modules/css-modules) to apply CSS st
locally and avoid leaking styles to the whole web application.
No additional configuration is needed since Create React App [supports CSS modules out of the box](https://create-react-app.dev/docs/adding-a-css-modules-stylesheet).

#### **Use classnames for complex CSS class names**

When a node has a class name that is either computed dynamically or is comprised of two or more classes, use the [classnames](https://www.npmjs.com/package/classnames) package (idiomatically imported typically as `cx`) to construct the class name string.

### Code splitting

If a component requires a large package, it can be loaded on demand by using the `lazy()` function from React.
Expand Down
3 changes: 3 additions & 0 deletions client/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@
"ckeditor",
"cktextarea",
"cloudstorage",
"codegen",
"codemirror",
"craco",
"dagre",
Expand Down Expand Up @@ -192,6 +193,7 @@
"objectstores",
"onloadend",
"onopen",
"openapi",
"papermill",
"pathname",
"pdfjs",
Expand Down Expand Up @@ -246,6 +248,7 @@
"tooltip",
"tspan",
"uiserver",
"ulid",
"uncompress",
"unicode",
"unmount",
Expand Down
Loading
Loading