Always specify the branch when dealing with datasets #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2972
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-2972.dev.renku.ch |
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2972
GitHub Actions
Inactive
lorenzo-cavazzi
force-pushed
the
000-fix-datasets-branches
branch
from
ec7e408 to
55cbef1
Compare
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2972
GitHub Actions
Inactive
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
lorenzo-cavazzi
added a commit
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a breaking change from the renku-core APIs that requires the clients to either always or never specify the branch name. The reason is that the branch is used for caching, and not sending one results in falling back to a default name instead of picking the default branch name.
Since we know the default branch and we are already using it somewhere, this PR updates the code to always pass the default branch name.
/deploy renku=remove-v9 renku-core=develop