Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve feedback when starting sessions on outdated projects #2985

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jan 19, 2024

If the project is outdated, provide a better explanation and a link to the sessions page.

Project can be updated with one click

image

Project requires more work to update

image

Fix #2983

/deploy

@ciyer ciyer requested a review from a team as a code owner January 19, 2024 13:23
@ciyer ciyer marked this pull request as draft January 19, 2024 13:33
@ciyer ciyer force-pushed the ciyer/2983-session-error-message branch 2 times, most recently from 1c6a451 to a7063a9 Compare January 19, 2024 14:19
@ciyer ciyer force-pushed the ciyer/2983-session-error-message branch from a7063a9 to cbd7238 Compare January 19, 2024 14:42
@ciyer ciyer temporarily deployed to renku-ci-ui-2985 January 19, 2024 15:08 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2985.dev.renku.ch

Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🚀

@ciyer ciyer merged commit 421d445 into master Jan 22, 2024
25 of 27 checks passed
@ciyer ciyer deleted the ciyer/2983-session-error-message branch January 22, 2024 08:24
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a better error message when session can't start on outdated projects
3 participants