Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): fix landing page parallax background #3010

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Jan 31, 2024

Fixes an issue with the parallax background on the landing page. The size of the background image was dependent on the browser's viewport which would create cases when the background image is repeated many times at a small size.

Before:
localhost_3000_ (5)
localhost_3000_ (6)

After:
localhost_3000_ (7)
localhost_3000_ (8)

@leafty leafty requested a review from andre-code January 31, 2024 12:53
@leafty leafty marked this pull request as ready for review January 31, 2024 12:53
@leafty leafty requested a review from a team as a code owner January 31, 2024 12:53
ciyer
ciyer previously approved these changes Feb 6, 2024
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This graphic may need to be re-thought, since, after the fix, the dots look disproportionately big on large viewports.

image

But I think your fix is an improvement over the status quo. 👍

@leafty
Copy link
Member Author

leafty commented Feb 6, 2024

This graphic may need to be re-thought, since, after the fix, the dots look disproportionately big on large viewports.

But I think your fix is an improvement over the status quo. 👍

I'm using a fixed size now which seems to stay consistent across all viewport sizes.

@leafty leafty requested a review from ciyer February 6, 2024 11:04
@ciyer
Copy link
Contributor

ciyer commented Feb 8, 2024

I'm using a fixed size now which seems to stay consistent across all viewport sizes.

Good idea, looks good on all viewport sizes now!

@leafty leafty merged commit 2dcfead into main Feb 8, 2024
12 checks passed
@leafty leafty deleted the leafty/fix-landing-parallax branch February 8, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants