Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not hide secret value input field #3233

Merged
merged 8 commits into from
Jul 29, 2024
Merged

fix: do not hide secret value input field #3233

merged 8 commits into from
Jul 29, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Jul 8, 2024

Fixes #3226.

Screenshot 2024-07-09 at 14 42 56
Screenshot 2024-07-09 at 14 43 00

/deploy #notest

@RenkuBot
Copy link
Contributor

RenkuBot commented Jul 8, 2024

You can access the deployment of this PR at https://renku-ci-ui-3233.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-3233 July 8, 2024 12:51 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3233 July 8, 2024 14:02 — with GitHub Actions Inactive
@leafty leafty marked this pull request as ready for review July 9, 2024 12:44
@leafty leafty requested a review from a team as a code owner July 9, 2024 12:44
@leafty leafty temporarily deployed to renku-ci-ui-3233 July 9, 2024 12:45 — with GitHub Actions Inactive
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this, and it works as advertised, but I have a comment.

This change causes the secrets to interact with my password manager, and I'm not sure that is what we want. Before, the field was treated as just a regular text field, and therefore ignored by the password manager, and I personally prefer that UX. I'm assuming that was the motivation for the initial implementation.

@leafty
Copy link
Member Author

leafty commented Jul 11, 2024

I tested this, and it works as advertised, but I have a comment.

This change causes the secrets to interact with my password manager, and I'm not sure that is what we want. Before, the field was treated as just a regular text field, and therefore ignored by the password manager, and I personally prefer that UX. I'm assuming that was the motivation for the initial implementation.

In that case we would simply have a text area field and the value would be visible (i.e. we remove the clumsy blur filter). That is how some apps handle secrets.

Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and works as expected. 👌

@leafty leafty changed the title fix: properly hide secret values fix: do not hide secret value input field Jul 29, 2024
@leafty leafty merged commit df5150e into main Jul 29, 2024
13 checks passed
@leafty leafty deleted the leafty/fix-3226 branch July 29, 2024 07:26
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User secrets do not get hidden in the input form
4 participants