-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: data connectors build #3323
Conversation
f48cce3
to
765e524
Compare
f70273a
to
21bf381
Compare
958c9ce
to
4447baa
Compare
* feat: support for data connectors on user and group namespaces (#3315) * feat: set/edit secrets for data connectors (#3330) * feat: data connectors on the project page (#3334) * feat: support launching sessions with data connectors (#3346) * minor: cosmetic improvements to data connectors (#3359) BREAKING CHANGE: Requires renku-data-services version >= 0.xx.0 BREAKING CHANGE: Requires renku-notebooks version >= 0.xx.0
d248d0a
to
688a6aa
Compare
You can access the deployment of this PR at https://renku-ci-ui-3323.dev.renku.ch |
There is a bug when starting a session and being prompted for credentials: if I provide credentials and select the "save" option, then there are two POST requests sent to start the session. The second one fails with a |
9a09cb3
to
d80b2ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏 This seems to work very well! 🎉
Tearing down the temporary RenkuLab deplyoment for this PR. |
feat: data connectors build
/deploy renku-data-services=leafty/build-data-connectors renku-notebooks=leafty/feat-data-connectors