Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: data connectors build #3323

Merged
merged 6 commits into from
Oct 17, 2024
Merged

feat: data connectors build #3323

merged 6 commits into from
Oct 17, 2024

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Sep 18, 2024

feat: data connectors build

/deploy renku-data-services=leafty/build-data-connectors renku-notebooks=leafty/feat-data-connectors

@ciyer ciyer added the ShapeUp label Sep 18, 2024
@ciyer ciyer changed the title wip: data connectors build [wip] data connectors build Sep 18, 2024
@ciyer ciyer force-pushed the build/data-connectors branch from f48cce3 to 765e524 Compare September 19, 2024 11:08
@ciyer ciyer force-pushed the build/data-connectors branch 2 times, most recently from f70273a to 21bf381 Compare October 4, 2024 07:50
@ciyer ciyer force-pushed the build/data-connectors branch 3 times, most recently from 958c9ce to 4447baa Compare October 14, 2024 10:08
ciyer added 4 commits October 16, 2024 13:09
* feat: support for data connectors on user and group namespaces (#3315)
* feat: set/edit secrets for data connectors (#3330)
* feat: data connectors on the project page (#3334)
* feat: support launching sessions with data connectors (#3346)
* minor: cosmetic improvements to data connectors (#3359)

BREAKING CHANGE: Requires renku-data-services version >= 0.xx.0
BREAKING CHANGE: Requires renku-notebooks version >= 0.xx.0
@ciyer ciyer force-pushed the build/data-connectors branch from d248d0a to 688a6aa Compare October 16, 2024 11:14
@ciyer ciyer changed the title [wip] data connectors build feat: data connectors build Oct 16, 2024
@ciyer ciyer marked this pull request as ready for review October 16, 2024 11:16
@ciyer ciyer requested a review from a team as a code owner October 16, 2024 11:16
@ciyer ciyer temporarily deployed to renku-ci-ui-3323 October 16, 2024 11:16 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3323.dev.renku.ch

@leafty
Copy link
Member

leafty commented Oct 16, 2024

There is a bug when starting a session and being prompted for credentials: if I provide credentials and select the "save" option, then there are two POST requests sent to start the session. The second one fails with a HTTP 500 which is shown as an error to the user. Going back to the project page, the session is starting and is working properly.

image

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 This seems to work very well! 🎉

@ciyer ciyer merged commit eb093e1 into main Oct 17, 2024
19 checks passed
@ciyer ciyer deleted the build/data-connectors branch October 17, 2024 07:28
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants