feat: add features for GitHub connections (2nd part) #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-3332
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3332.dev.renku.ch |
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-3332
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-3332
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-3332
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-3332
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-3332
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-3332
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-3332
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-3332
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-3332
GitHub Actions
Inactive
|
@leafty imports updated |
leafty
previously approved these changes
Oct 22, 2024
leafty
reviewed
Oct 24, 2024
| ) && ( | ||
| <WarnAlert dismissible={false}> | ||
| <p className="mb-2"> | ||
| The application is not active in any project nor namespace. |
There was a problem hiding this comment.
I think it should be "not active in any organization or user."
| <CardText>{app} is not installed.</CardText> | ||
| <WarnAlert dismissible={false}> | ||
| <p className="mb-2"> | ||
| The application is not installed in any project nor namespace yet. |
There was a problem hiding this comment.
Same, I think it should be "not installed in any organization or user."
leafty
had a problem deploying
to
renku-ci-ui-3332
GitHub Actions
Failure
leafty
temporarily deployed
to
renku-ci-ui-3332
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-3332
GitHub Actions
Inactive
|
@lorenzo-cavazzi this can be merged now |
leafty
added a commit
to SwissDataScienceCenter/renku-data-services
that referenced
this pull request
Oct 28, 2024
Add features to support GitHub connections. See SwissDataScienceCenter/renku-ui#3332
leafty
approved these changes
Oct 29, 2024
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
olloz26
pushed a commit
that referenced
this pull request
Nov 12, 2024
Update the "Connected services" interface and the admin page to support setting up and connecting to GitHub. BREAKING CHANGES: requires renku-data-services >= v0.25.0 --------- Co-authored-by: Flora Thiebaut <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3277
This PR considers a few more cases when connecting to GitHub. The idea is to provide more information to the user whenever the setup isn't complete.
/deploy