minor: fallback on the project id if the namespace is missing #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciyer
temporarily deployed
to
renku-ci-ui-3353
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3353.dev.renku.ch |
leafty
previously approved these changes
Oct 14, 2024
ciyer
had a problem deploying
to
renku-ci-ui-3353
GitHub Actions
Error
ciyer
force-pushed
the
ciyer/project-search-results-fix
branch
from
4677eab to
eb7714c
Compare
ciyer
temporarily deployed
to
renku-ci-ui-3353
GitHub Actions
Inactive
leafty
approved these changes
Oct 14, 2024
ciyer
temporarily deployed
to
renku-ci-ui-3353
GitHub Actions
Inactive
leafty
reviewed
Oct 15, 2024
| @@ -263,7 +263,7 @@ interface SearchV2ResultProjectProps { | |||
| project: Project; | |||
| } | |||
| function SearchV2ResultProject({ project }: SearchV2ResultProjectProps) { | |||
| const { creationDate, description, name, namespace, slug, visibility } = | |||
| const { creationDate, description, id, name, namespace, slug, visibility } = | |||
| project; | |||
|
|
|||
| const namespaceUrl = | |||
There was a problem hiding this comment.
Maybe we should have another fix where we don't show this if we get null from search.
leafty
temporarily deployed
to
renku-ci-ui-3353
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3353
GitHub Actions
Inactive
ciyer
had a problem deploying
to
renku-ci-ui-3353
GitHub Actions
Error
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production there is a case of a project that has no namespace in the search DB, but the ID is correct. This change should make the search display more robust against such projects.
/deploy renku=leafty/improve-cypress-tests