Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: namespace setting when current is not in results #3388

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Oct 29, 2024

Fixes an issue with projects in personal namespaces where the current namespace would not be selectable.

Screenshot 2024-10-30 at 16 06 23

The same issue would also exist for new groups which do not appear on the first page of results.

Other fixes:

  • Fix focus border on the namespace selector
  • Fix label and input id linking. Now clicking on the label focuses on the select element (can then press up or down to select a namespace).

/deploy renku=release-0.60.0

@leafty leafty temporarily deployed to renku-ci-ui-3388 October 29, 2024 12:17 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3388.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-3388 October 29, 2024 15:15 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3388 October 30, 2024 10:31 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3388 October 30, 2024 13:15 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3388 October 30, 2024 14:57 — with GitHub Actions Inactive
@leafty leafty marked this pull request as ready for review October 30, 2024 15:10
@leafty leafty requested a review from a team as a code owner October 30, 2024 15:10
@leafty leafty temporarily deployed to renku-ci-ui-3388 October 30, 2024 15:11 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3388 October 30, 2024 15:19 — with GitHub Actions Inactive
@leafty leafty changed the title wip: fix namespace setting fix: namespace setting when current is not is results Oct 31, 2024
@leafty leafty temporarily deployed to renku-ci-ui-3388 October 31, 2024 08:08 — with GitHub Actions Inactive
@leafty leafty changed the title fix: namespace setting when current is not is results fix: namespace setting when current is not in results Oct 31, 2024
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🚀

@leafty leafty merged commit 047ee92 into main Nov 4, 2024
41 of 43 checks passed
@leafty leafty deleted the leafty/fix-project-settings-namespace branch November 4, 2024 08:21
@RenkuBot
Copy link
Contributor

RenkuBot commented Nov 4, 2024

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants