Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create data connector in project #3525

Merged

Conversation

olevski
Copy link
Member

@olevski olevski commented Feb 4, 2025

This is the initial implementation.

Things that are missing:

  • no tests
  • the way that data connectors in projects are displayed is not right
  • the backend is still a bit wonky and will not support everything (i.e. launching sessions fails)

/deploy renku-data-services=feat-add-project-as-dc-owner-pt2

@olevski olevski requested a review from a team as a code owner February 4, 2025 13:52
@olevski olevski marked this pull request as draft February 4, 2025 13:52
@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 4, 2025

You can access the deployment of this PR at https://renku-ci-ui-3525.dev.renku.ch

Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR changes make overall sense so far 👍 Some early comments inline.

In short, there is a better way to add types from the updated APIs from other repos branches, and there is some less-than-ideal prop drilling here -- tho the components you are touching here weren't the most straightforward and your solution looks acceptable in this case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these types are up-to-date in the renku-data-service branch feat-add-project-as-dc-owner-pt2, instead of creating an enhanced-api file, you should take the up-to-date spec file from there, overwrite the namespace.openapi.json file here and run the npm command npm run generate-api:namespaceV2.
We use the enhanced version mainly for extending the APIs -- usually transforming the response into a more convenient object (transformResponse) or using the tags to auto-refetch content (providesTags on GET and invalidatesTags on the other verbs)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not changed in the backend. But I think I will have to update them in the backend. For now I am kind of forcing the project namespace in a few places. And that is why I need this. I will remove this when it is fully integrated in the backend. I think I will be able to do this during the build.

@olevski olevski force-pushed the feat-create-data-connector-in-project branch from a5d23a6 to da6d1c7 Compare February 6, 2025 12:14
@olevski olevski temporarily deployed to renku-ci-ui-3525 February 6, 2025 12:14 — with GitHub Actions Inactive
Co-authored-by: Lorenzo Cavazzi <[email protected]>
@olevski
Copy link
Member Author

olevski commented Feb 11, 2025

This change is part of the following stack:

Change managed by git-spice.

Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🚀

@olevski olevski merged commit f600423 into build-project-authz-disentangle Feb 19, 2025
19 checks passed
@olevski olevski deleted the feat-create-data-connector-in-project branch February 19, 2025 09:23
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants