Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable NetPol for Solr. #3512

Merged
merged 1 commit into from
Mar 27, 2024
Merged

feat: enable NetPol for Solr. #3512

merged 1 commit into from
Mar 27, 2024

Conversation

aledegano
Copy link
Contributor

@aledegano aledegano commented Feb 22, 2024 •
edited
Loading

This change to the values files of Solr enables a network policy to Solr such that only search-api and search-provision are allowed to connect to it.
/deploy

@RenkuBot
Copy link
Collaborator

You can access the deployment of this PR at https://ci-renku-3512.dev.renku.ch

@aledegano aledegano marked this pull request as ready for review February 22, 2024 13:52
@aledegano aledegano requested a review from a team as a code owner February 22, 2024 13:52
@aledegano aledegano requested a review from a team as a code owner February 22, 2024 14:07
lokijuhy
lokijuhy approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@lokijuhy lokijuhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hearby approve the addition of a blank line in the changelog

@aledegano
feat: enable Network Policy for Solr.
22d042d 
This change to the values files of Solr enables a network policy
to Solr such that only `search-api` and `search-provision` are
allowed to connect to it.
@aledegano aledegano force-pushed the enable_netpol_solr branch from 24893be to 22d042d Compare March 26, 2024 08:22
@rokroskar
Copy link
Member

I hearby approve the addition of a blank line in the changelog

you could also consider requesting a change to the changelog... ;)

@aledegano
Copy link
Contributor Author

There is an issue with this change: enabling the NetPol breaks the probes, so Solr keeps restarting (even though from the logs it seems to be fine...).
I'm investigating further.

@rokroskar
Copy link
Member

rokroskar commented Mar 26, 2024 •
edited
Loading

@aledegano this passes now - I nuked the namespace and redeployed. The deployment was borked and there was an issue with the Solr credentials.

@aledegano
Copy link
Contributor Author

@aledegano this passes now - I nuked the namespace and redeployed. The deployment was borked and there was an issue with the Solr credentials.

Thank you, yes it works now. I also verified that search-api and search-provision are indeed the only 2 pods that are allowed to connect to Solr.

I am merging this now then.

@aledegano aledegano merged commit f928120 into build/search-and-discovery-1.0 Mar 27, 2024
16 checks passed
@aledegano aledegano deleted the enable_netpol_solr branch March 27, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jachro jachro jachro approved these changes

@lokijuhy lokijuhy lokijuhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aledegano @RenkuBot @rokroskar @jachro @lokijuhy