Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading the project to the new format #43

Merged
merged 5 commits into from
May 31, 2017
Merged

Conversation

artiomchi
Copy link
Member

Upgrading the project from the legacy .xproj format to the new .csproj project format, and the project runtime from dnx to .NET Standard and .NET Core

Since a number of classes have been removed (like the Roslyn's ICompileModule) some code has been temporarily commented out. I've also taken the liberty of recreating the Host app from scratch with a new project template, since the one currently there is very outdated, and was not worth manually updating.

@artiomchi
Copy link
Member Author

I've not touched build.cmd and makefile.shade (since I don't know your AppVeyor config), and the unit tests will fail because of this line

@artiomchi
Copy link
Member Author

Based on one of my projects in AppVeyor, I mocked up something like this as a basic start:

dotnet --info
appveyor-retry dotnet restore -v Minimal

dotnet build "src\R4Mvc"
dotnet build "src\R4MvcHostApp"
dotnet build "src\R4Mvc.Test"

cd test\R4Mvc.Test
dotnet test

@artiomchi artiomchi mentioned this pull request May 30, 2017
@kevinkuszyk
Copy link
Member

Thanks for this. All looks good to me. We have the build.cmd because AppVeyor has having trouble building .net core apps early on. I'll switch it back to build the solution.

To be honest, I don't recall why we have the makefile.shade. I'll also ignore those tests for now.

@kevinkuszyk kevinkuszyk merged commit b7d3c53 into T4MVC:master May 31, 2017
@kevinkuszyk kevinkuszyk added this to the alpha1 milestone Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants