adding shortcuts on the video player buttons controltext #1317
+100
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1317.test.live.mm.rbg.tum.de in a few minutes. Logins
|
SebiWrn
requested changes
Apr 22, 2024
|
If you still want to merge this PR please reopen the PR and fix the issues |
karjo24
requested review from
a team
and removed request for
alexanderstephan
| @@ -74,7 +74,7 @@ | |||
| <p class="font-semibold">Signed in as</p> | |||
| <span>@{{$user.Name}}</span> | |||
| </header> | |||
| <nav class="d-grid gap-3 font-light"> | |||
| <nav class="d-grid gap-3 font-light" x-data="{showPopup: false}"> | |||
There was a problem hiding this comment.
Are we sure we want this on every page and not just on the watch page? The shortcuts are only relevant there, right?
| </div> | ||
| <p>Keyboard Shortcuts</p> | ||
| </div> | ||
| <div x-ref="keyboardShortcutsPopup" x-show="showPopup" class="tum-live-popup-container overlay" @keydown.escape.window="showPopup=false;"> |
There was a problem hiding this comment.
I think this should be cloaked: https://alpinejs.dev/directives/cloak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
fixes #1289
Description
Steps for Testing
Screenshots
It used to say only play, not the keyboard shortcuts are also displayed.
Keyboard shortcuts in menu:
Keyboard shortcuts popup: