Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Driven Dialog Boxes [Ready] #659

Merged
merged 26 commits into from
Aug 24, 2016
Merged

Code Driven Dialog Boxes [Ready] #659

merged 26 commits into from
Aug 24, 2016

Conversation

dustinwloring1988
Copy link
Contributor

@dustinwloring1988 dustinwloring1988 commented Aug 23, 2016

I know this is a rather big merge but I think it will be for the better since it was focused on making the UI more code driven like @quill18, and I think most of us, wanted from the start.

  • All dialog boxes are now code driven.
  • KeyboardController is not a monobehaviour.
  • DialogBoxManager now is code driven
    Other small changes to make the UI more code driven

After this get accept I should have another ready tomorrow after work that will finish up making the UI "more"code driven.
YAY FINALLY!!!!!!!!!!!

@dustinwloring1988 dustinwloring1988 changed the title Code Driven Dialog Boxes Code Driven Dialog Boxes #Code Driven UI Aug 23, 2016
@dustinwloring1988 dustinwloring1988 mentioned this pull request Aug 23, 2016
@bjubes
Copy link
Collaborator

bjubes commented Aug 23, 2016

Please explain exactly how to make a dialog box in your new system. If this change does go through we all need to know how to work the new UI

@dustinwloring1988
Copy link
Contributor Author

dustinwloring1988 commented Aug 23, 2016

First off sorry im on my phone I will make a pdf with picture if it gets accepted.

How To make a new Dialog Box

  • Make a empty scene.
  • Make your dialog box in here then save the prefab to the Resource Folder.
  • Delete the new scene you made.
  • Open the DialogBoxManager and copy a box of code that made and input your new info there.

How to open your dialog box (from a button)

  • Put a script on your dialog box the derived from DialogBox.
  • Get a refreance to DialogBoxManager.
  • Call that with get component your refreance name for DialogBoxManager. Then the refreance your script name with "." showdialog.
  • Done.

@dustinwloring1988
Copy link
Contributor Author

@bjubes - done
Next commit I do will have the menu update and it now uses a gride layout this will be nice for rescaling.

@alexanderfast alexanderfast changed the title Code Driven Dialog Boxes #Code Driven UI [WIP] Code Driven Dialog Boxes #Code Driven UI Aug 23, 2016
@alexanderfast
Copy link
Collaborator

Marked as [WIP], more commits incoming.

@dustinwloring1988
Copy link
Contributor Author

dustinwloring1988 commented Aug 23, 2016

No, its not a work in progress. Spliting up the uploads as to keep the changes smaller so it wont conflict with othere PR's

@dustinwloring1988 dustinwloring1988 changed the title [WIP] Code Driven Dialog Boxes #Code Driven UI Code Driven Dialog Boxes #Code Driven UI Aug 23, 2016
@dustinwloring1988 dustinwloring1988 changed the title Code Driven Dialog Boxes #Code Driven UI Code Driven Dialog Boxes [Ready] Aug 23, 2016
@dustinwloring1988
Copy link
Contributor Author

Hoping this will get accepted in the next couple hours then I can have a fresh branch to work on the other changes when I get home and all will be done tonight. This way by this time tomorrow no more SCENE changes.YAY!!!!!!!!!! 👍 :)

@dustinwloring1988
Copy link
Contributor Author

I will be closing this pull in about 2.5 hours from now. I just though getting the UI out of the SCENE was IMPORTANT.

@WardBenjamin
Copy link
Collaborator

@dustinwloring1988 This can't be merged because it conflicts. If you can fix these then we can properly look at it and (hopefully) merge it.

@WardBenjamin WardBenjamin changed the title Code Driven Dialog Boxes [Ready] Code Driven Dialog Boxes [Conflicts] Aug 23, 2016
@dustinwloring1988
Copy link
Contributor Author

When I get home I will fix it once that is it I'm not going to keep fixing it over and over it's been up for 24 hours and needs posted or it's obvious that nobody wants it

@alexanderfast
Copy link
Collaborator

You have to understand that this young project is moving extremely rapidly, everything is volatile. Scene changes is a known problem and this is and extreme example. If you're tired of playing catch up with the other work, maybe find someone that can pick this up?

Or maybe find someone to just test it. While there are a few us that can actually merge it, anyone can test it. Finding someone thats willing to pull your branch, test it, and come here and formally vouch for it would speed it up greatly.

@dustinwloring1988 dustinwloring1988 changed the title Code Driven Dialog Boxes [Conflicts] [Good To Go Plz Commit] Code Driven Dialog Boxes Aug 23, 2016
@dustinwloring1988
Copy link
Contributor Author

@WardBenjamin @Mizipzor It works now

@dustinwloring1988
Copy link
Contributor Author

Please commit so I can finish the UI stuff so we dont have conflicts with the SCENE anymore it is driving me crazy

@dustinwloring1988 dustinwloring1988 changed the title [Good To Go Plz Commit] Code Driven Dialog Boxes Code Driven Dialog Boxes [Ready] Aug 23, 2016
@svmnotn
Copy link
Contributor

svmnotn commented Aug 23, 2016

alt text

@svmnotn
Copy link
Contributor

svmnotn commented Aug 23, 2016

Other than the following:

  • the temp_trade button in options
  • if any changes are made to the settings you get UnassignedReferenceException

Not sure if these are in the scope but they do work in master.

@dustinwloring1988
Copy link
Contributor Author

Those will be the first 2 I fix just I just dont want to make this commit change any more files

@dustinwloring1988
Copy link
Contributor Author

@svmnotn - Thanks for testing it

@WardBenjamin
Copy link
Collaborator

Looks good! Please do fix those issues though.... better to get this merged now though. Merging!

@WardBenjamin WardBenjamin merged commit 6d9489c into TeamPorcupine:master Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants