-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x86/avx_mathfun.h: Remove fallback warnings #3527
Conversation
Build test with following configurations:
Both build passes. |
Tested only with non-AVX2 build as my build server does not support AVX2 (Intel Ivy Bridge-EP Xeon E5). All unit testes passes with some modification in Seems the relative path of the files to be loaded is wrong, it should be ncnn/tests/test_squeezenet.cpp Line 170 in 2d46994
|
Codecov Report
@@ Coverage Diff @@
## master #3527 +/- ##
==========================================
- Coverage 92.44% 92.20% -0.25%
==========================================
Files 551 551
Lines 151934 152603 +669
==========================================
+ Hits 140451 140702 +251
- Misses 11483 11901 +418
Continue to review full report at Codecov.
|
My build setup issue, please ignore this. |
This patch removes warning messages indicating falling back to SSE2 when AVX2 support is disabled as suggested. Also reorders non-AVX2 macros for readability and faster preprocessing. Suggested-by: nihui <[email protected]> Signed-off-by: Kagurazaka Kotori <[email protected]>
38c9476
to
08dbd1b
Compare
Thanks for your contribution ! |
This patch removes warning messages indicating falling back to SSE2
when AVX2 support is disabled as suggested. Also reorders non-AVX2
macros for readability and faster preprocessing.
Suggested-by: nihui [email protected]
Signed-off-by: Kagurazaka Kotori [email protected]