-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[help needed][packaging] add pkgconfig #3984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put ncnn.pc.in and cmake rules in src directory
install to ${CMAKE_INSTALL_LIBDIR}/pkgconfig
prefix=@CMAKE_INSTALL_PREFIX@
Codecov Report
@@ Coverage Diff @@
## master #3984 +/- ##
==========================================
- Coverage 93.89% 92.92% -0.97%
==========================================
Files 728 675 -53
Lines 177006 159274 -17732
==========================================
- Hits 166200 148007 -18193
- Misses 10806 11267 +461
Continue to review full report at Codecov.
|
this will hardcode absolute path of install prefix when it's builded which is not ideal especially when we are providing prebuilt releases |
Signed-off-by: sodo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution ! |
i'm not sure where should i put these codes can i get some feedback?
tested on windows(using mingw)