Don't silently ignore errors in VkCompute::submit_and_wait #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #4769 +/- ##
==========================================
- Coverage 94.90% 94.90% -0.01%
==========================================
Files 779 779
Lines 224202 224204 +2
==========================================
- Hits 212773 212772 -1
- Misses 11429 11432 +3
|
nihui
requested changes
Jun 12, 2023
| cmd.submit_and_wait(); | ||
|
|
||
| return 0; | ||
| return cmd.submit_and_wait(); |
There was a problem hiding this comment.
The callee returned a possible error, but the caller did not handle it
| cmd.submit_and_wait(); | ||
|
|
||
| return 0; | ||
| return cmd.submit_and_wait(); |
There was a problem hiding this comment.
The callee returned a possible error, but the caller did not handle it
| } | ||
|
|
||
| int ret; | ||
|
|
| @@ -2499,18 +2505,18 @@ int Extractor::extract(int blob_index, Mat& feat, int type) | |||
| #if NCNN_BENCHMARK | |||
| cmd.create_query_pool(d->net->layers().size() * 2); | |||
| #endif // NCNN_BENCHMARK | |||
|
|
|||
| int ret; | |||
There was a problem hiding this comment.
the ret variable is already declared earlier. this line is not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a problem when there was "vkQueueSubmit failed" error printed in console but ncnn::Extractor::extract doesn't return any error because return value of submit_and_wait isn't checked.