-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strong Number Using Indirect recursion #1564
Conversation
Math Programs (WoC) HarshCasper#1527
Math Programs (WoC) HarshCasper#1527
Java/math/StrongRecursion.java
Outdated
@@ -0,0 +1,47 @@ | |||
//checking for a strong number using indirect recursion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a description of the Algorithm/Code that you are looking to implement
Java/math/StrongRecursion.java
Outdated
import java.util.*; | ||
class StrongRecursion | ||
{ | ||
public static int sofd(int n) //recursive function for sum of factorial of digits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use meaningful function and variable names
Java/math/StrongRecursion.java
Outdated
* | ||
* | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a newline at the end of the file
Added description of algorithm/code Changed function name Modified comment lines Made user input more friendly Added new line at the EOF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes done @HarshCasper . Go over it.
Java/math/StrongRecursion.java
Outdated
* | ||
*/ | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra lines of code
Java/math/StrongRecursion.java
Outdated
} | ||
} | ||
|
||
/* Sample Input And Output ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:
not ;
Java/math/StrongRecursion.java
Outdated
public static int sumOfFactorialOfDigit(int n) | ||
|
||
{ | ||
if(n==0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format the Code with spaces around the Operators
Removed extra lines of code Formatted space around operators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If any other problems present than indentation, do say @HarshCasper
changed ; to :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErzaTitania-2001 Rename the program to check_strong_number.java
. Also, Format your code using code formatter.
Changed class name Formatted code using https://www.tutorialspoint.com/online_java_formatter.htm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErzaTitania-2001 Rename the program StrongRecursion.java
to check_strong_number.java
.
Changed class name
@iamrajiv , should I close this pull request ? I want to pull another request on another program. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Bucket Sort HarshCasper#1590
Bucket Sort HarshCasper#1590
@HarshCasper @iamrajiv , I made a commit for the issue Bucket Sort #1590 in the same pull request by mistake. Any solutions to this problem? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErzaTitania-2001 Remove the Bucket Sort program from this PR and make another PR for Bucket Sort. Also, whenever you make PR make separate branches for each PR rather than committing to the master branch.
@iamrajiv Done. Deleted Bucket_Sort. When is the PR gonna be merged? |
Have you read the Contributing Guidelines on Pull Requests?
yes
Description
(Write your answer here.)
Checklist
README.md
and link to my code.Related Issues or Pull Requests
Math Programs (WoC) #1527