fix: #736 - MoveTo implementation for MockDirectoryInfo under TestingHelpers #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afroze9
changed the title
afroze9
changed the title
afroze9
changed the title
|
Thanks, I'll have a look by by the end of this week! |
fgreinacher
suggested changes
Jul 11, 2022
There was a problem hiding this comment.
Thanks a lot for your contribution @afroze9! Please have a look at the failing tests and ping me once they are fixed 🙇
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
Fixes #736: > In a unit test which consists on moving directory using the MoveTo function from IDirectoryInfo doesn't update the IDirectoryInfo entries and the moved directory info keeps the same initial values. However using the same function on the debug and release modes( FileSystem) does update the fields and properties of the DirectorytInfo *Note: This should make #864 obsolete!*
|
Superseded by #972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #736.
Made changes to the
MockDirectoryInfounderSystem.IO.Abstractions.TestingHelpers.MoveTonow updates thedirectoryNamewhen moving the directory to the destination folder.This should also fix the following methods (if they are called after
MoveTois called):