Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1117 - Navbar causes session creation in a stateless f:view #1118

Conversation

exabrial
Copy link
Contributor

Navbar causes session creation. Use a private static concurrent map instead of the server session

…static concurrent map instead of the server session
@exabrial exabrial changed the title WIP: Fix #1117 - Navbar causes session creation Fix #1117 - Navbar causes session creation Jan 14, 2020
@exabrial exabrial changed the title Fix #1117 - Navbar causes session creation Fix #1117 - Navbar causes session creation in a stateless f:view Jan 14, 2020
@exabrial
Copy link
Contributor Author

The only downside to this approach is that if the lifecycle is stopped between the static call to addResource and the system event firing, you'll have a key stuck in the map, resulting in a memory leak. This may or may not be possible under the JSF lifecycle, I actually don't know enough about it to make a good judgement call.

@exabrial
Copy link
Contributor Author

Hey guys, has anyone had time to evaluate this? thank you

@geopossachs geopossachs self-requested a review January 28, 2020 18:12
@geopossachs
Copy link
Collaborator

i would rather not like to keep data in a listner. i think but we can use the attributes of the components. I have prepared a pr on your idea. please check if this would work for sessionless. I would reject this

#1123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants