Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow webpack 2 and 3 as peerDependencies #14

Merged
merged 2 commits into from
Aug 28, 2017

Conversation

gabro
Copy link
Contributor

@gabro gabro commented Jul 10, 2017

Despite the changes in webpack 2, this plugin is still needed in some instances (see for example the discussion here: TypeStrong/ts-loader#108).

I've tested it with webpack 2 and 3 and it works as intended.

gabro added 2 commits July 10, 2017 16:15
Despite the changes in webpack 2, this plugin is still needed in some instances (see for example the discussion here: TypeStrong/ts-loader#108).
@TiddoLangerak
Copy link
Owner

TiddoLangerak commented Jul 14, 2017

I'll try to find some time to look into this soon(ish). I got to say thought that to me it sounds like a problem with the ts-loader. Webpack 2 & 3 have proper functionality to make the build fail with a non-zero exit code, which other loaders manage to use just fine. Do you happen to know if other loaders experience similar issues?

@gabro
Copy link
Contributor Author

gabro commented Jul 14, 2017

I don't know any other, but if you read the linked issue (you can go directly to the latest messages) it appears that webpack 2/3 still has some hiccups with errors and exit codes.

@pksunkara
Copy link

I support this. Webpack 2/3 is still having issues.

@TiddoLangerak
Copy link
Owner

I unfortunately don't have time to investigate this fully, but since this is apparently an issue for more people I'll merge this PR and make a new release.

@TiddoLangerak TiddoLangerak merged commit ce3acab into TiddoLangerak:master Aug 28, 2017
@gabro
Copy link
Contributor Author

gabro commented Aug 28, 2017

Thank you @TiddoLangerak, appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants