-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move commercial features to Enterprise Edition #108
Conversation
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; we should think of how to compensate for the test coverage losses.
</valueSelector> | ||
</kOptListMoveSelector> | ||
<kOptListMoveSelector /> | ||
<!-- With Timefold Solver Enterprise Edition, uncomment the following to enable Nearby Selection: --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of combinations got commented out as expected. However, this impacts:
a) performance tests in timefold-examples (if they run these configurations)
b) turtle tests (assuming there are some turtle tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, there are no turtle tests, so having at least some will be an improvement.
There's an issue for that already.
🎉 This issue has been resolved in |
Enterprise Edition repo is temporarily private.
It will become public once ready.