Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move commercial features to Enterprise Edition #108

Merged
merged 13 commits into from
Jun 19, 2023

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Jun 19, 2023

Enterprise Edition repo is temporarily private.
It will become public once ready.

triceo added 4 commits June 19, 2023 08:21
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
@triceo triceo changed the title chore: move commercial features to Advanced Edition chore: move commercial features to Enterprise Edition Jun 19, 2023
triceo added 9 commits June 19, 2023 11:51
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
Signed-off-by: Lukáš Petrovický <[email protected]>
@triceo triceo requested a review from rsynek June 19, 2023 13:10
Copy link
Contributor

@rsynek rsynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; we should think of how to compensate for the test coverage losses.

</valueSelector>
</kOptListMoveSelector>
<kOptListMoveSelector />
<!-- With Timefold Solver Enterprise Edition, uncomment the following to enable Nearby Selection: -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of combinations got commented out as expected. However, this impacts:
a) performance tests in timefold-examples (if they run these configurations)
b) turtle tests (assuming there are some turtle tests)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, there are no turtle tests, so having at least some will be an improvement.
There's an issue for that already.

@triceo triceo merged commit dc7eafe into TimefoldAI:main Jun 19, 2023
@triceo triceo deleted the advanced branch June 19, 2023 14:30
@timefold-release
Copy link
Contributor

🎉 This issue has been resolved in v0.10.0 (Release Notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants