perf: read value range size instead of the value range #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsynek
approved these changes
Aug 14, 2023
triceo
force-pushed
the
valuerange-on-entity
branch
from
93e7587 to
64ff136
Compare
|
@rsynek Please re-review, I decided to add one more change. (Deprecating uncountable, because that really barely ever works and never should have been added.) |
To read an entire value range to get its size, the value range needs to be first converted to a collection. This is costly and we therefore implement a shortcut that allows to read the size without creating a collection.
triceo
force-pushed
the
valuerange-on-entity
branch
from
64ff136 to
93ba91e
Compare
rsynek
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To read an entire value range to get its size,
the value range needs to be first converted to a collection.
This is costly and we therefore implement a shortcut,
allowing us to read the size without creating a collection.