Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change the default moves for multi-variable domain models #936

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

zepfred
Copy link
Contributor

@zepfred zepfred commented Jul 5, 2024

This pull request updates the list of default moves for multi-variable domain models.

@zepfred zepfred linked an issue Jul 5, 2024 that may be closed by this pull request
@zepfred zepfred requested a review from triceo July 5, 2024 16:02
@triceo
Copy link
Contributor

triceo commented Jul 5, 2024

I'm not entirely sure why the test coverage for this is in the Enterprise repo.
This doesn't need enterprise, does it? If not, the coverage should be here.

@zepfred
Copy link
Contributor Author

zepfred commented Jul 5, 2024

I'm not entirely sure why the test coverage for this is in the Enterprise repo. This doesn't need enterprise, does it? If not, the coverage should be here.

That's correct, and it doesn't require the enterprise module. I could move it to the solver repo, but we won't test the scenario where the user enables nearby auto-configuration on a multi-variable domain model.

@triceo
Copy link
Contributor

triceo commented Jul 7, 2024

Personally, I don't think we need to test it in this way at all.
Just use the factory and test that it returns the correct defaults.

Copy link

sonarqubecloud bot commented Jul 8, 2024

@triceo triceo merged commit e7fae26 into TimefoldAI:main Jul 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chained model with additional planning variable is no longer working
2 participants