refactor: Use strong typedef for network family. #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2641 +/- ##
==========================================
- Coverage 73.09% 73.09% -0.01%
==========================================
Files 149 149
Lines 30533 30559 +26
==========================================
+ Hits 22319 22337 +18
- Misses 8214 8222 +8 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
bitwise-family
branch
10 times, most recently
from
132b8bd to
32b4edf
Compare
iphydf
force-pushed
the
bitwise-family
branch
from
32b4edf to
03b3474
Compare
iphydf
force-pushed
the
bitwise-family
branch
from
12cfaec to
f6be32a
Compare
github-actions
bot
added
the
refactor
iphydf
force-pushed
the
bitwise-family
branch
from
f6be32a to
fa2b3a3
Compare
iphydf
force-pushed
the
bitwise-family
branch
from
fa2b3a3 to
708361f
Compare
Green-Sky
reviewed
Feb 1, 2025
| return -1; | ||
| } | ||
|
|
||
| target->family = family_from_net_family(family); | ||
|
|
||
| if (net_family_is_ipv4(target->family) || net_family_is_tox_tcp_ipv4(target->family)) { | ||
| memcpy(target->ip.v4.uint8, data + 1, SIZE_IP4); |
There was a problem hiding this comment.
might be worth making the following memcpy() dependent on is_ipv6()
Green-Sky
approved these changes
Feb 1, 2025
iphydf
force-pushed
the
bitwise-family
branch
from
708361f to
9284446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is