delete minor unreachable code caused by t.Fatal or log.Fatal (#4219)

Signed-off-by: Abirdcfly <[email protected]>
TykTechnologies · Aug 5, 2022 · 2b1018d · 2b1018d
1 parent fce0346
commit 2b1018d
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 8 deletions.
diff --git a/cli/bundler/bundler.go b/cli/bundler/bundler.go
@@ -101,7 +101,6 @@ func (b *Bundler) Build(ctx *kingpin.ParseContext) error {
 			ch := text[0:1]
 			if ch != "y" {
 				log.Fatal("Aborting")
-				os.Exit(1)
 			}
 		}
 	} else {

diff --git a/cli/importer/importer.go b/cli/importer/importer.go
@@ -67,23 +67,19 @@ func (i *Importer) Import(ctx *kingpin.ParseContext) (err error) {
 		err = i.handleSwaggerMode()
 		if err != nil {
 			log.Fatal(err)
-			os.Exit(1)
 		}
 	} else if *i.bluePrintMode {
 		err = i.handleBluePrintMode()
 		if err != nil {
 			log.Fatal(err)
-			os.Exit(1)
 		}
 	} else if *i.wsdlMode {
 		err = i.handleWSDLMode()
 		if err != nil {
 			log.Fatal(err)
-			os.Exit(1)
 		}
 	} else {
 		log.Fatal(errUnknownMode)
-		os.Exit(1)
 	}
 	os.Exit(0)
 	return nil

diff --git a/test/tcp.go b/test/tcp.go
@@ -73,17 +73,14 @@ func (r TCPTestRunner) Run(t testing.TB, testCases ...TCPTestCase) error {
 		if tc.ErrorMatch != "" {
 			if err == nil {
 				t.Fatalf("[%d] Expected error: %s", ti, tc.ErrorMatch)
-				break
 			}
 
 			if !strings.Contains(err.Error(), tc.ErrorMatch) {
 				t.Fatalf("[%d] Expected error %s, got %s", ti, err.Error(), tc.ErrorMatch)
-				break
 			}
 		} else {
 			if err != nil {
 				t.Fatalf("[%d] Unexpected error: %s", ti, err.Error())
-				break
 			}
 		}
 	}