Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-9231] Fix go plugin error responses #5142

Conversation

PatrickTaibel
Copy link
Contributor

Description

Don't send an error message if the go plugin itself did that already.

Related Issue

#5141

Motivation and Context

The change of #4922 causes Tyk to always send an error message to the client when an error within a go plugin occurs. In case the error is caused by a sent status code >= 400 by the plugin itself this is not desiderable as it will append the Tyk error message to an already existing response from the plugin.

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

@andyo-tyk andyo-tyk changed the title Fix go plugin error responses [TT-9231] Fix go plugin error responses Jul 10, 2023
@lghiur
Copy link
Member

lghiur commented Oct 5, 2023

@PatrickTaibel thanks for the PR. We've realised internally that this was caused by a recent change we've done, so we handled the fix in a different PR #5562.

Closing this one for now, and thanks for the contribution.

@lghiur lghiur closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants