Do not create program multiple times when there are no changes in fil…

…es (#747) TypeScript cant tell if there is invalidation because of custom module resolution, that means it needs to create new program whenver asked for Fixes #746
TypeStrong · Mar 17, 2018 · caec556 · caec556
1 parent 0936566
commit caec556
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -255,6 +255,7 @@ function updateFileInCache(
   }
 
   if (instance.watchHost && fileWatcherEventKind !== undefined) {
+    instance.hasUnaccountedModifiedFiles = true;
     instance.watchHost.invokeFileWatcher(filePath, fileWatcherEventKind);
     instance.watchHost.invokeDirectoryWatcher(path.dirname(filePath), filePath);
   }

diff --git a/src/instances.ts b/src/instances.ts
@@ -25,13 +25,16 @@ const instances = <TSInstances>{};
 
 function ensureProgram(instance: TSInstance) {
   if (instance && instance.watchHost) {
-    if (instance.changedFilesList) {
-      instance.watchHost.updateRootFileNames();
-    }
-    if (instance.watchOfFilesAndCompilerOptions) {
-      instance.program = instance.watchOfFilesAndCompilerOptions
-        .getProgram()
-        .getProgram();
+    if (instance.hasUnaccountedModifiedFiles) {
+      if (instance.changedFilesList) {
+        instance.watchHost.updateRootFileNames();
+      }
+      if (instance.watchOfFilesAndCompilerOptions) {
+        instance.program = instance.watchOfFilesAndCompilerOptions
+          .getProgram()
+          .getProgram();
+      }
+      instance.hasUnaccountedModifiedFiles = false;
     }
     return instance.program;
   }

diff --git a/src/interfaces.ts b/src/interfaces.ts
@@ -256,6 +256,7 @@ export interface TSInstance {
     typescript.BuilderProgram
   >;
   program?: typescript.Program;
+  hasUnaccountedModifiedFiles?: boolean;
   changedFilesList?: boolean;
 }