Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make invalid options supplied to the loader be reported as an error #629

Closed
johnnyreilly opened this issue Sep 10, 2017 · 1 comment
Closed
Assignees

Comments

@johnnyreilly
Copy link
Member

At present invalid loader options are just ignored.

About once a week or so, someone will raise an issue against ts-loader about ts-loader not working. Further investigation often reveals this to be a configuration issue. Since this results in a fair amount of wasted time (and also that I suspect not everyone goes to the trouble of raising an issue here) I'm planning to make ts-loader throw an error when invalid options are supplied.

Fail fast and fix it is the aim of the game.

If anyone knows of any reason why this could be problematic to them then do speak up - otherwise this is likely to ship in the next release of ts-loader.

Although this is strictly speaking a "breaking changes" change I'm probably not going to increment the version just for this. My reasoning is: anyone who is broken by this already has a broken config and will likely be grateful for the new information. Again, if anyone has other views on this I'm open to hearing them.

Thanks!

@johnnyreilly johnnyreilly self-assigned this Sep 10, 2017
@johnnyreilly
Copy link
Member Author

See #630

johnnyreilly added a commit that referenced this issue Sep 10, 2017
* Start validating loader option names
* test harness ignores 'at C:/source/ts-loader/dist/index.js:90:19' style row number / column number differences
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant