-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.6 was missing from Travis / AppVeyor build matrices. #1011
Merged
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
aa8e7ee
Update .travis.yml
johnnyreilly 479d501
Update appveyor.yml
johnnyreilly 3123a19
update comparison tests
johnnyreilly 3e384d9
update to TS 3.6.3
johnnyreilly 767dd78
make comparison test tolerant of different spaces
johnnyreilly 43b9352
Fix when config includes referenced project sources and outputs as well
sheetalkamat 686856b
Always run comparison test without transpile
sheetalkamat ab14f97
ignore case when matching file paths
sheetalkamat 994bb22
Merge pull request #1013 from sheetalkamat/moreFixes
sheetalkamat ab890a3
Update CHANGELOG.md
johnnyreilly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,9 +14,10 @@ install: | |
| - yarn lint | ||
| - yarn add $TYPESCRIPT | ||
| env: | ||
| - [email protected] | ||
| - TYPESCRIPT=typescript@next | ||
| - [email protected] | ||
| - [email protected] | ||
| - TYPESCRIPT=typescript@next | ||
| - [email protected] | ||
| - [email protected] | ||
| - [email protected] | ||
|
|
@@ -27,4 +28,4 @@ env: | |
| - [email protected] | ||
| - [email protected] | ||
| - [email protected] | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,9 +3,10 @@ environment: | |
| FORCE_COLOR: 1 | ||
| nodejs_version: "10" | ||
| matrix: | ||
| - TYPESCRIPT: [email protected] | ||
| - TYPESCRIPT: typescript@next | ||
| - TYPESCRIPT: [email protected] | ||
| - TYPESCRIPT: [email protected] | ||
| - TYPESCRIPT: typescript@next | ||
| - TYPESCRIPT: [email protected] | ||
| - TYPESCRIPT: [email protected] | ||
| - TYPESCRIPT: [email protected] | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest changing to 3.6.3 instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup will do. Somehow I managed to forget to add 3.6.x to the build matrix when I upgraded the comparison test pack. Whoops. Fixing now. As far as I can assess there's no problems that have been introduced in the meantime, though I'm regenerating some of the project references test pack output again (which makes sense given the changes that have happened)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will push update in 15 minutes or so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done - now let's see how CI gets on