Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for symlinks in project references #1136

Merged
merged 15 commits into from
Jul 8, 2020
Merged

Support for symlinks in project references #1136

merged 15 commits into from
Jul 8, 2020

Conversation

sheetalkamat
Copy link
Contributor

Fixes #1114

@johnnyreilly
Copy link
Member

Nice work @sheetalkamat!

I can see there's a bunch of failing tests which you're no doubt looking into. Having had a quick look it seems that TypeScript <= 2.6 tests are failing.

I've been wondering about dropping support for older versions of TypeScript; maybe making the minimum supported version TypeScript 3.6. It would speed up our CI considerably as we'd have a much smaller test matrix to run in Travis / AppVeyor. Users on older versions of TypeScript would still have older versions of ts-loader they could use.

If it makes your life easier, then do feel free to consider doing that in this PR. TypeScript 2.6 was a long time ago!

This was referenced Jul 4, 2020
Closed
Merged
@johnnyreilly johnnyreilly requested a review from andrewbranch July 4, 2020 07:37
@johnnyreilly
Copy link
Member

johnnyreilly commented Jul 4, 2020 •
edited
Loading

From the looks of it this is done @sheetalkamat? Thanks so much for your work! @andrewbranch would you be able to give this a review when you get a chance please?

I've also upgraded the version in the package.json to 8.0.0 and put an entry in the CHANGELOG.md - so that when we're ready to ship we can just go go go 😄

@andrewbranch
Copy link
Contributor

Yep, I will do it this week if not today. 🚀

andrewbranch
andrewbranch approved these changes Jul 8, 2020
View reviewed changes
test/comparison-tests/projectReferencesSymLinks/common/src/index.ts
@@ -0,0 +1 @@
export const getMeaningOfLife2 = () => 45;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

45?! 😱

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a sick mind right there 😉

@johnnyreilly johnnyreilly merged commit 4ad247a into master Jul 8, 2020
@johnnyreilly
Copy link
Member

Shipping now https://github.com/TypeStrong/ts-loader/releases/tag/v8.0.0

Thanks for all your work @sheetalkamat and thanks for the review @andrewbranch!

@sheetalkamat sheetalkamat deleted the symLinks branch July 8, 2020 21:48
jedster1111 added a commit to jedster1111/ts-loader-project-references that referenced this pull request Jul 10, 2020
@jedster1111
Upgrade ts-loader to make use of bug fix
086460a 
Proved yarn workspaces, project references & ts-loader work together.
Fixed in  TypeStrong/ts-loader#1136
@appzuka appzuka mentioned this pull request Jul 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyreilly johnnyreilly johnnyreilly left review comments

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output while using project references is using the previous dependent package output instead of the current
3 participants
@sheetalkamat @johnnyreilly @andrewbranch