-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include standard webpack start/end locations in emitted errors #1255
Include standard webpack start/end locations in emitted errors #1255
Conversation
This looks good - thanks for contributing! Could you update the |
bbbae2f
to
348dddc
Compare
Done! |
Keep getting a failing test.. rerunning |
@johnnyreilly yeash, I was thinking it was a known problem with the Travis setup. |
Passing now - go figure |
https://github.com/TypeStrong/ts-loader/releases/tag/v8.0.17 - released! Thanks for contributing 🌻❤️ |
This PR adds the
loc
property to all errors coming from TypeScript diagnostics.The property is the webpack "API" way of indicating the precise location of an error, including its end location.
In this way, the errors produced by
ts-loader
can be processed from the webpackStats
object, with no knowledge ofts-loader
.The previous location property is still available, so the change is backward-compatible.
Webpack will print its own error location string in the string output, in addition to the line and character that
ts-loader
already includes in the error message. All comparison tests are updated to expect the new output.Closes #1199