-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add zero-config support for fork-ts-checker-webpack-plugin #1451
feat: add zero-config support for fork-ts-checker-webpack-plugin #1451
Conversation
Hey @piotr-oles - I know who you are! 😅 I think this is a great improvement! Could we make an enhancement? With the current implementation, you can't explicitly control If someone wants to run with So passing |
Actually, I read that wrong - your PR already implements the behaviour I mentioned. Could you update the |
Sure, I will do that! |
6e2b2f4
to
35e65c7
Compare
Done! ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship it!
Hi! 👋
I'm a maintainer of the fork-ts-checker-webpack-plugin.
Currently, we have to set
transpileOnly: true
to skip type-checking on the loader side.With this change it's no longer the case - the loader will detect if there is a checker plugin in the configuration and set default transpileOnly: true if that's the case. I hope this will improve DX and make webpack config files cleaner and smarter :)
Before:
After:
I tested this manually, please let me know if you need some automatic tests for this.