Declarations update independent of compiler.watchFileSystem #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses watching.compiler.fileTimestamps which is set directly in the compiler. See https://github.com/webpack/webpack/blob/master/lib/Compiler.js#L105. Fixes the TypeStrong#155 when using the webpack.OldNodeWatchFileSystem.
|
Please merge this pr. It'll helpful. opichals, thank u, u save me hour 👍 |
|
I plan on it. Meant to get it out in the last release but somehow missed it. Will go out in the next. |
|
Good. It's also solve same problem if use webpack.WatchIgnorePlugin ;) |
|
@jbrantly any plans to merge this soon? |
benelliott
pushed a commit
to benelliott/awesome-typescript-loader
that referenced
this pull request
Aug 2, 2016
…OldWatchPlugin or WatchIgnorePlugin
s-panferov
added a commit
to s-panferov/awesome-typescript-loader
that referenced
this pull request
Aug 3, 2016
This was referenced Aug 15, 2016
This was referenced Aug 15, 2016
This was referenced Sep 6, 2016
|
Hey can we get an npm publish for this? The latest npm version does not have this fix. |
|
Hi @pllee, I've just started getting to grips with the project (literally yesterday). I'm planning to do an npm publish as soon as I feel it's safe. I need to do some more testing and then I'll try and give it a go. |
|
Ok thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses watching.compiler.fileTimestamps which is set directly in
the compiler. See https://github.com/webpack/webpack/blob/master/lib/Compiler.js#L105.
Fixes the #155
when using the webpack.OldNodeWatchFileSystem.