-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support project references #817
Merged
johnnyreilly
merged 44 commits into
TypeStrong:master
from
andrewbranch:project-references
Sep 23, 2018
+1,614
−174
Merged
Changes from 14 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
92f23b3
Pass project references to language service
andrewbranch 55d8efa
Use parsed project references, not raw content
andrewbranch 75a5bdb
Don’t fail while trying to emit/diagnose files in project references;…
andrewbranch 05ee14d
Be tolerant of older TypeScript versions
andrewbranch 157211e
Add project references to transpileOnly mode
andrewbranch ee61c63
Add project references to experimental watch API path
andrewbranch 0b81aa3
Use JS output for files in project references
andrewbranch 0a42045
Fix loader emit typings
andrewbranch c01af17
Get program out of language service too
andrewbranch 0d2854c
Add comparison test for project references without source maps
andrewbranch 615bcbb
Add comparison test for project references with source map (no warnings)
andrewbranch 2f4ff59
Add test for unbuilt project references
andrewbranch 1e765b2
Only warn once per project per compilation about source maps
andrewbranch d262970
Make comments more accurate
andrewbranch 700e967
Implement getOutputJavaScriptFileName
andrewbranch 741bf9b
Add test for project references with outDir (and fix implementation)
andrewbranch f36a841
Be safer in getProjectReferenceForFile
andrewbranch 05ab35d
Fix type error
andrewbranch 565dab2
Add JS files instead of TS files to loader dependencies for project refs
andrewbranch a224efc
Add comments
andrewbranch 80528ea
Cache project reference info in files map
andrewbranch 47515ed
Update test for updated stack trace
andrewbranch 451c462
Don’t repeatedly check files that don’t have project refs for project…
andrewbranch 266a4ba
Rename test project reference output to a folder that’s not gitignored 😂
andrewbranch cc90401
Merge branch 'master' into project-references
johnnyreilly d532f78
Don’t ignore map files important to projectReferences tests
andrewbranch 29d02b9
Normalize windows paths before comparing
433630b
Use only relative paths in error messages
andrewbranch 80a28cd
Update expected output to remove absolute path from error message
andrewbranch fe888e2
Ignore path differences in TS error message
andrewbranch ddc5cc7
Theoretically protect against getProjectReferences changes in typescr…
andrewbranch 6c87188
Update README with project references
andrewbranch 611e8d9
Put projectReferences behind a loaderOption
andrewbranch 32e2882
Update validateLoaderOptions and test loader options
andrewbranch e47664b
Update validateLoaderOptionNames test
andrewbranch 2f196b3
ignore projectReferencesOutDir on windows in non-transpile mode
johnnyreilly b235502
add execution test for project references
johnnyreilly 5d190fa
General tweaks; I should really get tslint properly set up
johnnyreilly 16a9e7c
some yarn lint stuff
johnnyreilly b6510a0
further tslint fixes
johnnyreilly fbed24b
fix broken appenSuffixes
johnnyreilly 308f0dd
add linting to build
johnnyreilly a6b203c
update changelog
johnnyreilly ca2c576
Merge branch 'master' into project-references
johnnyreilly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that the whole tsbuild API is now internal, this uses an internal function? I couldn't find a custom implementation if it in this PR