Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a mask field to Geometry class #38

Closed
travissluka opened this issue Dec 8, 2020 · 4 comments · Fixed by #51
Closed

add a mask field to Geometry class #38

travissluka opened this issue Dec 8, 2020 · 4 comments · Fixed by #51
Assignees

Comments

@travissluka
Copy link
Member

travissluka commented Dec 8, 2020

on creation Geometry should read in a land mask from a file (separate from what is being done in State now), specified by the yaml configuration and save the mask in an atlas field contained in Geometry

@travissluka
Copy link
Member Author

if the mask is loaded and saved to Geometry::atlasFieldSet_ in the Geometry constructor, adding it as an integer field with the field name "gmask", them BUMP should be able to do land masking if

mask_check: 1
network: 1

is added to the bump section of staticbinit.yml

@loganchen39
Copy link
Collaborator

@travissluka I'm working on this issue. How are supposed to get this land mask file? Are we supposed to produce this file ourselves with respect to the 1x1 degree background grid, or is there already such a file?

@travissluka
Copy link
Member Author

yes, I would just create a new file with a 1 or 0 mask value based on the the current 1x1 background file we're using.

@loganchen39
Copy link
Collaborator

loganchen39 commented Jan 28, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants