Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use land mask when initializing bump #40

Closed
travissluka opened this issue Dec 8, 2020 · 4 comments · Fixed by #55
Closed

Use land mask when initializing bump #40

travissluka opened this issue Dec 8, 2020 · 4 comments · Fixed by #55
Assignees

Comments

@travissluka
Copy link
Member

use the land mask when initializing BUMP horizontal convolution.

@travissluka
Copy link
Member Author

Add to the staticbinit, var, and dirac:
mask_check: 1
network: 1

@loganchen39
Copy link
Collaborator

@travissluka The staticbinit failed the test after adding these two items, I'll check.

@travissluka
Copy link
Member Author

travissluka commented Feb 9, 2021 via email

@loganchen39
Copy link
Collaborator

Yes I deleted all the files first, it generated all of the netCDF files which look ok, but it failed the tests for staticbinit, dirac and var. I'll check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants