Resolve bug in Low-NOx formation of SOA #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed addition to the PR template
Removed duplicate term of 2.0*ETHA[1] from the formula for VOC. Note that this formula is currently commented out in the spec def file.
Updated with information on using daily average HCMAQ output to create boundary condition files for domains in the Northern Hemisphere.
havalapye
approved these changes
Dec 7, 2021
|
Thanks @havalapye. Yes I think I accidentally started on the 5.3.3 branch where these updates have been made? Is that right @kmfoley? |
|
This PR passes the following build and run checks: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contact:
Ben Murphy (US EPA)
Type of code change:
Bug Fix
Description of changes:
Replace NRXN surrogates in the SOA table with HRXN surrogates.
Summary of Impact:
A typo in the SOA_DEFN data table resulted in high NOx reactions contributing to low-NOx species, which are quite low in volatility. Considerable impact on SOA if using AE6. No impact for AE7. This typo is believed to have been introduced in v5.3.