Fixed name errors in camera_picamera2.py module #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlou05
reviewed
Feb 18, 2025
modules/camera/camera_picamera2.py
Outdated
Comment on lines
101
to
102
| if picamera2 is None: | ||
| return False, None |
There was a problem hiding this comment.
Did this never work? Like it still failed to pass test with this in?
There was a problem hiding this comment.
Yeah that didn't work. What's probably happening is that all the methods of the class are setup on Python reads the types of the methods on instantiation so this doesn't catch the NoneType error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.