Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not perform a slice if there are error values in the settings #7

Closed
awhiemstra opened this issue May 15, 2015 · 2 comments
Closed
Labels
Type: Bug The code does not produce the intended behavior.
Milestone

Comments

@awhiemstra
Copy link
Contributor

Application Version: 15.05.90
Platform: Arch Linux 64-bit
Qt: 5.4.1
PyQt: 5.4.1
Diplay Driver: xf86-video-intel 2.99.917

Steps to Reproduce:

  • Load a model.
  • Switch to "Advanced" mode.
  • Open the "Quality" tab
  • Set "Layer Height" to 0

Actual Results:

  • The text box turns red to indicate an error but then slicing starts and the engine will crash every time until the Layer Height is set back to something > 0.

Expected results:

  • The text box turns red and slicing does not start.

Additional Information:

  • After some discussion with BagelOrb we decided that we should assume error values are incorrect values and not slice if there are any, whereas warning values are things we think are invalid values but which may work. We should make sure we have correct error and warning values on settings.
@awhiemstra awhiemstra added the Type: Bug The code does not produce the intended behavior. label May 15, 2015
@awhiemstra awhiemstra added this to the 15.06 Final milestone May 15, 2015
@nallath
Copy link
Member

nallath commented May 15, 2015

This is a big change compared to original cura, where red values are assumed to be wrong, but still sent to the engine. It won't 'block'.

@awhiemstra
Copy link
Contributor Author

We tested this with layer height in the legacy Cura. With a layer height of 0 legacy Cura will not slice. In addition, right now the difference between the two things is rather vague, so this gives the actual values proper definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The code does not produce the intended behavior.
Projects
None yet
Development

No branches or pull requests

2 participants