Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default time window scaling overflow #1040

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Fix default time window scaling overflow #1040

merged 6 commits into from
Nov 17, 2023

Conversation

kkarbowiak
Copy link
Contributor

@kkarbowiak kkarbowiak commented Nov 17, 2023 •
edited by jcoupey
Loading

Issue #1020

Tasks

  • Update CHANGELOG.md (remove if irrelevant)
  • review

@jcoupey jcoupey added this to the v1.14.0 milestone Nov 17, 2023
jcoupey
jcoupey approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@jcoupey jcoupey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I just added a similar change for scale_*_user_cost in 44b1042 and f8022df.

@jcoupey jcoupey merged commit b545622 into VROOM-Project:master Nov 17, 2023
@jcoupey jcoupey mentioned this pull request Nov 17, 2023
Closed
@kkarbowiak kkarbowiak deleted the fix/tw-scaling-overflow branch November 20, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoupey jcoupey jcoupey approved these changes

Assignees
No one assigned
Labels
bug plan mode
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kkarbowiak @jcoupey