Refactor/exception #641
Merged
Refactor/exception #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathf
force-pushed
the
refactor/exception
branch
from
0ddb66f to
0af1ff1
Compare
jcoupey
approved these changes
Jan 13, 2022
3 tasks
This was referenced Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue #639
Solution deprecates both
ERRORandget_code. the solution for getting the error code is not super elegant, but it is simple and it does have the advatage of keeping the error codes close to their associated Exception class and being the single point of truth.I've isolated this part of the PR in a single commit, so it is super easy to revert if you rather we use enums and
get_code.Tasks
docs/API.mdCHANGELOG.md