Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds command line option -v to print vroom version #655

Closed
wants to merge 1 commit into from
Closed

Adds command line option -v to print vroom version #655

wants to merge 1 commit into from

Conversation

hklarner
Copy link

Issue

Please link to an existing issue (or open one before submitting a PR).

Tasks

  • ...
  • Update docs/API.md (remove if irrelevant)
  • Update CHANGELOG.md (remove if irrelevant)
  • review

@jcoupey
Copy link
Collaborator

jcoupey commented Jan 24, 2022

While I'm 100% in for this addition (most users would expect this flag, and probably --version too), I don't think it would be wise to adjust the existing command-line parsing since we have a pending refactor in #604.

@hklarner
Copy link
Author

I see, makes sense. I'll close this PR.

@hklarner hklarner closed this Jan 24, 2022
@nilsnolde
Copy link
Contributor

Thanks @hklarner that's a good idea, I'll include it in that PR once I get back to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants