WIP: Handling jk motion for cjk and full width characters #9471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To handle full width character correctly (as VSCode does and neovim/vim) on jk motions
Which issue(s) this PR fixes
This is to address issue: #4096
Special notes for your reviewer:
The code is WIP (needs cleaning after making sure things work), the changes broke the logic of
desiredColumnproperty.I am trying to understand why we need it (since VSCode already handles this properly), and how to fix it.
If anybody want to contribute to the PR, please do so, or at least share your ideas ❤️.
helpful files from VSCode repo:
https://github.com/microsoft/vscode/blob/f253ed1e6c2868ba648681a3a7942603c2ba836b/src/vs/editor/common/cursor/cursorMoveOperations.ts#L157
https://github.com/microsoft/vscode/blob/main/src/vs/editor/common/core/cursorColumns.ts#L25
https://github.com/microsoft/vscode/blob/main/src/vs/base/common/strings.ts#L687