Special fishing fix #849
Open
Special fishing fix #849
+76
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix special fish handling in rod.dm fixes turfcatching, adds put_in_hands, gives sprites to specialrarity, name and sellprice to special fish Update /obj/item/fishing/bait/deluxe in tackle.dm makes enchanted bait less broken by lowering specialchance from 20 to 5 and specialfish cost from 6400 to 480 fixes capital letters in types Prepare fish.dm for sprite reroute reroute default fish icon_state adds cooked swordfish icon_state just for fun Change icon_states in fish.dmi uses Vanderlin-Tales-Of-Wine#703 sprites, changes [fishname]com states to [fishname] Update swordfish icon_state in abyssor.dm reroutes outdated spritepath in swordfish icon_state
adds baitpenalty to fish, fixing the inability to fish with it
|
|
|
fish sprites merged so update the pull so it no longer conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes fishing handling to properly support special rarities, sizes, types and catch location.
Changes fishes iconstates from [fishname]com to [fishname], which fixes missing sprites on default fishes (R.I.P. invisible clownfish) and prevents further problems.
Puts catched fish in the hands.
Makes deluxe bait work as intended, although tunes it down a little (20% chance to catch 6400 mammon fish is NOT OKAY. now it's 5% for 480 mammon).
Fixes inability to catch anything using fish as bait.
fish.dmi is ported from #703 , if it's reverted after testing ping me to fix it
Why It's Good For The Game
It's a fix?.. I think having the ability to make special fish rarities/sizes/types for certain baits is super cool, and it should work as it was intended
Imagine reeling an alive bog troll when fishing using sinew bait💀 hope someone makes something like thatPre-Merge Checklist