Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality for add certificate, add product, and edit certificate buttons. #8

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

saharbueno
Copy link

@saharbueno saharbueno commented Jun 4, 2024

  • Added Add Certificate and Add Product buttons
  • When the button is pressed -> popup opens, and the user can add all details, the user can cancel (which closes the popup and clears input), or the user can add the item (adds input to the database, adds input to the row, and closes the popup)
  • Added Edit Certificate button

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for vara-eco ready!

Name Link
🔨 Latest commit eaa3b23
🔍 Latest deploy log https://app.netlify.com/sites/vara-eco/deploys/666344c0b07b8800085e07fd
😎 Deploy Preview https://deploy-preview-8--vara-eco.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@shraddha55 shraddha55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link

@ShaktidharK1997 ShaktidharK1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

suggestion : You can change the input type of expiration_date, last_audited and last_exported to date instead of text in the product / certificate forms

@ShaktidharK1997
Copy link

ShaktidharK1997 commented Jun 5, 2024

useEffect(() => { fetchSupplierData() fetchProductData() fetchCertificateData() }, [supplierData])

@saharbueno I noticed there's a loop in this statement. It's causing repeated API calls to the backend because it checks for supplierData as a dependency, and in the hook, supplierData gets fetched and updated. Could we change the dependency to avoid this loop?

Screenshot from 2024-06-05 11-10-16

@saharbueno saharbueno changed the title Added functionality for add certificate and add product buttons. Added functionality for add certificate, add product, and edit certificate buttons. Jun 7, 2024
@saharbueno saharbueno merged commit 9cc4e1d into VaraEco:master Jun 7, 2024
4 checks passed
@saharbueno saharbueno deleted the add-buttons branch June 8, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants